make GitHubActions also run tests for netstd #2995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build and test the netstd library so there is some basic testing.
V3 is based on Node.js v16 and will get deprecated. Currently it's just causing a warning. With v4 the artifact-upload action fails as all matrix-jobs use the same name and the default prevents overwriting existing ones. Therefore we use individual artifact names which will also preserve all logs, not just a singe one only. Cherry-picked from PR apache#2994 to avoid incompatibility between v3 and v4 in same workflow.
SvenRoederer
force-pushed
the
netstd-tests
branch
from
86ddb52
to
129b421
Compare
avoid v3/v4 incompatibility
|
This change was made to run tests for #2993 issue (which only affects v0.20.0) and therefore base on v0.20 branch. The current PR also relies on some changes of #2994 ans it should probably merged after it. |
|
@SvenRoederer could you send another PR with the added tests only targeting |
|
Closing, to send an updated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a job to build and run tests for netstd. Also upload the binaries as artifact.
This gives basic testing, but leaves including to cross-test for the future.
Most job-steps are copied from the other jobs.
In relation to #2994 it already uses artifact-action v4 and ubuntu-22.04 (ubuntu-20.04 has issues with dotnet-support).