Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket): add error handling #29538

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(websocket): add error handling #29538

merged 2 commits into from
Jul 10, 2024

Conversation

harshit2283
Copy link
Contributor

SUMMARY

Adding Error handling in websocket to avoid crashing whole service due to a faulty socket etc

Certain Browsers (i.e Safari) don't play nicely with WS Protocol, they can end up crashing the whole service. ref

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
@dosubot dosubot bot added browser:safari Related to the Safari browser global:error Related to global errors affecting the platform labels Jul 10, 2024
github-actions[bot]
github-actions bot reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.
villebro
villebro approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!
@villebro
Copy link
Member

@harshit2283 it seems there's a linting error. Can you fix it so we can get this merged?
@harshit2283
Copy link
Contributor Author

@harshit2283 it seems there's a linting error. Can you fix it so we can get this merged?

Have fixed it.
@villebro villebro merged commit 1d35ca4 into apache:master Jul 10, 2024
34 checks passed
@villebro
Copy link
Member

btw @harshit2283 as you appear to be using GAQ with websockets, it would be valuable to get your feedback on a recent proposal to simplify the GAQ architecture: #29515
@harshit2283
Copy link
Contributor Author

@villebro Sure, I will check it out. Thank you!
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@harshit2283 @eschutho
fix(websocket): add error handling (#29538)
d397df6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:safari Related to the Safari browser global:error Related to global errors affecting the platform size/XS
2 participants
@harshit2283 @villebro