[SPARK-48832][CONNECT][TESTS] Add dedicated error tests for Spark Connect #47250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
approved these changes
Jul 8, 2024
HyukjinKwon
reviewed
Jul 11, 2024
| @@ -24,7 +24,7 @@ | |||
| from pyspark.errors.utils import ErrorClassesReader | |||
|
|
|||
|
|
|||
| class ErrorsTest(unittest.TestCase): | |||
| class ErrorsTestsMixin: | |||
There was a problem hiding this comment.
I think it doesn't test anything specific to Spark Connect?
There was a problem hiding this comment.
It's true. I suggest this in case we add more test related to connect in the future. We can just close this for now.
There was a problem hiding this comment.
let's add it when we actually need a dedicated test
There was a problem hiding this comment.
Got it! Let me close for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add dedicated error tests for Spark Connect
Why are the changes needed?
To improve the test coverage for Spark Connect
Does this PR introduce any user-facing change?
No, this is test-only fix.
How was this patch tested?
Extended the existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No.