SLING-11571 repoinit: allow add or remove mixin types #36
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
|
||
| @Test | ||
| public void removeMixinFromNotExistingPath() throws Exception { | ||
| // this should just log a warning and continue |
There was a problem hiding this comment.
FWIW you could use a LogCapture utility to verify logging, as done in https://github.com/apache/sling-org-apache-sling-graphql-core/blob/d430d47df5b190107d413f31ef19052aacab4d98/src/test/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutorLoggingTest.java
There was a problem hiding this comment.
Thanks for the review. I've incorporated the suggested change at: #38
| U.parseAndExecute("create path /removeOneMixinOnOnePath(nt:unstructured mixin mix:lockable)"); | ||
| U.assertNodeExists("/removeOneMixinOnOnePath", "nt:unstructured", Collections.singletonList("mix:lockable")); | ||
|
|
||
| U.parseAndExecute("remove mixin mix:lockable from /removeOneMixinOnOnePath"); |
There was a problem hiding this comment.
I think If "remove mixin" always removed all mixins the current tests wouldn't catch that. I'd add two mixins initially and remove one after the other to make sure selective removing works.
There was a problem hiding this comment.
Thanks for the review. I've incorporated the suggested change at: #38
| U.assertNodeExists("/removeTwoMixinsOnOnePath1", "nt:unstructured", Arrays.asList("mix:lockable","mix:referenceable")); | ||
| U.assertNodeExists("/removeTwoMixinsOnOnePath2", "nt:unstructured", Arrays.asList("mix:lockable","mix:referenceable")); | ||
|
|
||
| U.parseAndExecute("remove mixin mix:lockable,mix:referenceable from /removeTwoMixinsOnOnePath1,/removeTwoMixinsOnOnePath2"); |
There was a problem hiding this comment.
Same comment as above about not testing selective removal of mixins
There was a problem hiding this comment.
Thanks for the review. I've incorporated the suggested change at: #38
No description provided.