Adding a new option to make adding the suffix to the include optional #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfmitchell - seems your PR has slipped, sorry about that. Can you please add a Jira issue so we can better track the issue and reference it in your commits? You should probably also rebase your commits since they now conflict with the master branch. Thanks! |
|
@rombert Sorry for the delay - rebased and Jira issue raised. |
|
Thanks for the contribution @jfmitchell , I've just merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a use case where by we needed to make the include semi dynamic. We wanted the parent page that included suffixes to not be cacheable - but wanted the included resources to be cached. This was for a search results page, where it was necessary to cache the content of an individual search result - but not the actual results to display.
However, since the parent request had a suffix - this was passed onto the included resources, which made them non-cacheable. This "appendSuffix" option was added to maintain the current default behaviour, but allow it to be toggled off.