Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-904] Add Spring 6-related exclusions to Shiro BOM #955

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[GH-904] Add Spring 6-related exclusions to Shiro BOM #955

merged 1 commit into from
Jun 28, 2023

Conversation

fpapon
Copy link
Member

@fpapon fpapon commented Jun 24, 2023

Fix #904
@lprimak lprimak added shiro-2.0.0 java Pull requests that update Java code spring Spring and SpringBoot labels Jun 24, 2023
@lprimak lprimak requested review from bdemers and bmarwell June 24, 2023 21:14
@lprimak
Copy link
Contributor

lprimak commented Jun 24, 2023

Should we add a test for SpringBoot?
@lprimak lprimak added this to the 2.0 milestone Jun 24, 2023
@fpapon
Copy link
Member Author

fpapon commented Jun 25, 2023

Should we add a test for SpringBoot?

I'm trying to add a sample module but I need to go deeper to exclude spring5 vs spring6 and springboot2 vs springboot3.
May be it can be another PR?
@fpapon fpapon merged commit 232cb0e into apache:main Jun 28, 2023
24 checks passed
@fpapon fpapon deleted the GH-904 branch June 28, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code shiro-2.0.0 spring Spring and SpringBoot
2 participants
@fpapon @lprimak