Reworked CDI principal injection API using Supplier #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprimak
force-pushed
the
principal-injection-holder
branch
from
1e9a596
to
e79a977
Compare
lprimak
force-pushed
the
principal-injection-holder
branch
from
e79a977
to
531a929
Compare
lprimak
force-pushed
the
principal-injection-holder
branch
from
531a929
to
560b0e0
Compare
lprimak
force-pushed
the
principal-injection-holder
branch
from
6d710c8
to
ba2681f
Compare
bmarwell
reviewed
Mar 30, 2023
| assertNotNull(injectedComponents.getPropertyPincipal()); | ||
| assertEquals("user", injectedComponents.getPropertyPincipal().orElseThrow().getUserName()); | ||
| assertNotNull(injectedComponents.getPropertyPrincipal()); | ||
| assertEquals("user", Optional.ofNullable(injectedComponents.getPropertyPrincipal().get()).orElseThrow().getUserName()); |
There was a problem hiding this comment.
Don't use get(), use orElseThrow() (on 8 with NoSuchElementException::new)
There was a problem hiding this comment.
get() comes from Supplier now, not Optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
Optional, using genericSupplierobject as an injection point