Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle fluent setters #751

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Properly handle fluent setters #751

merged 1 commit into from
Feb 22, 2023

Conversation

leleuj
Copy link
Contributor

@leleuj leleuj commented Feb 22, 2023

Currently, if I have a bean with a fluent setter (meaning it does not return void but this), it is ignored in my shiro.ini file.

This PR fixes the problem.

I found out the issue when upgrading buji-pac4j to pac4j v6. Here is the local patch: bujiio/buji-pac4j@6fb21b1#diff-ab7750a1c3bbcd663e2b0750f1ac11eac16b93c7ef5da9b8eb43af3d90ef7868R95
@lprimak
Copy link
Contributor

lprimak commented Feb 22, 2023

Looks great. Can you squash the commits please?
@leleuj
Copy link
Contributor Author

leleuj commented Feb 22, 2023

Sure. I just squashed the three commits into one.
@lprimak lprimak merged commit 16b65ee into apache:main Feb 22, 2023
@leleuj leleuj deleted the fluentsetter branch February 23, 2023 06:05
@leleuj leleuj mentioned this pull request Feb 23, 2023
Merged
@leleuj
Copy link
Contributor Author

leleuj commented Feb 23, 2023

Thanks. Backported to: #753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@leleuj @lprimak