Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-671] Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll #714

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Feb 4, 2023

Add Shiro support for jSR 250 security annotations

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

fpapon
fpapon previously requested changes Feb 6, 2023
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lprimak Can you squash the commits?

@@ -23,6 +23,7 @@
import org.apache.shiro.web.config.WebIniSecurityManagerFactory;
import org.apache.shiro.web.env.IniWebEnvironment;
import org.apache.shiro.web.filter.mgt.DefaultFilter;
import org.omnifaces.util.Beans;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to import this dependency? (Beans::getInstance)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and it's already imported into Jakarta EE so this is not "new"

@lprimak lprimak dismissed fpapon’s stale review February 6, 2023 20:25

Commits squashed now that CDI has been merged

@lprimak lprimak requested a review from fpapon February 6, 2023 20:26
@lprimak lprimak self-assigned this Feb 6, 2023
@lprimak lprimak added shiro-2.0.0 java Pull requests that update Java code labels Feb 6, 2023
@lprimak lprimak added this to the 2.0 milestone Feb 6, 2023
@lprimak lprimak merged commit 92af573 into apache:main Feb 11, 2023
@lprimak lprimak deleted the roles-allowed branch February 11, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code shiro-2.0.0
2 participants