Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-337] Combine all previous work on CDI #695

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Jan 28, 2023

  • Factored out CDI module from existing Jakarta EE module
  • Enables Shiro components to be CDI Injectable
  • Makes Named CDI beans available in shiro.ini

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak marked this pull request as draft January 28, 2023 01:54
@lprimak lprimak self-assigned this Jan 28, 2023
@lprimak lprimak added shiro-2.0.0 java Pull requests that update Java code labels Jan 28, 2023
@lprimak lprimak added this to the 2.0 milestone Jan 28, 2023
@lprimak lprimak force-pushed the cdi-module-integration branch 4 times, most recently from 233fc85 to 58bdf02 Compare January 29, 2023 06:49
@lprimak lprimak marked this pull request as ready for review February 3, 2023 22:07
@lprimak lprimak force-pushed the cdi-module-integration branch 4 times, most recently from a8e40e8 to 684f1e7 Compare February 6, 2023 01:23
- added ability to inject Shiro components with CDI
- added ability to reference CDI / EL (at)Named beans in shiro.ini
- aligned Jakarta artifact names with the rest of Shiro
- randomize Payara ports
@lprimak lprimak merged commit 64a87a8 into apache:main Feb 6, 2023
@lprimak lprimak deleted the cdi-module-integration branch February 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code shiro-2.0.0
2 participants