Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-899] moved the HttpSessionContext Jakarta shim into Shiro pack… #557

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 30, 2022

…age and out of jakarta package to made Java modules work,
and avoid split package issues

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

fpapon
fpapon previously requested changes Dec 2, 2022
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lprimak please avoid commit spacing text change

…age and out of jakarta package,

to made JPMS work, and avoid split package issues
@lprimak lprimak force-pushed the native-sessions-jakarta-modular branch from 56cce79 to 8fa5852 Compare December 3, 2022 19:40
@lprimak lprimak requested a review from fpapon December 3, 2022 19:41
@lprimak
Copy link
Contributor Author

lprimak commented Dec 3, 2022

@fpapon Split up whitespace commit into a separate commit

@lprimak lprimak dismissed fpapon’s stale review December 6, 2022 04:31

Fixed / done as requested

@lprimak lprimak requested a review from bmarwell December 7, 2022 00:50
@lprimak lprimak merged commit de73559 into apache:main Dec 7, 2022
@lprimak lprimak deleted the native-sessions-jakarta-modular branch December 7, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants