[SHIRO-890] Avoid another proxy creator when @EnableAspectJAutoProxy enabled

[georgecao]

See #268 for the previous fix. But when @EnableAspectJAutoProxy enabled, spring actually creates an instance of AnnotationAwareAspectJAutoProxyCreator but not DefaultAdvisorAutoProxyCreator. In this situation, there will be two proxy creators in the same context, which leads to methods be proxied twice also .

The fix may just remove the type value of the @ConditionalOnMissingBean.

    @Bean
    @DependsOn("lifecycleBeanPostProcessor")
    @ConditionalOnMissingBean(name = AopConfigUtils.AUTO_PROXY_CREATOR_BEAN_NAME)
    @Override
    public DefaultAdvisorAutoProxyCreator defaultAdvisorAutoProxyCreator() {
        return super.defaultAdvisorAutoProxyCreator();
    }

[fpapon]

@georgecao thanks for the PR! Is there a way to add a unit test to validate the fix?

[georgecao]

@fpapon Sure. Will come back when unit test is ready.

[georgecao]

@bdemers I formats the pom.xml by IntellIJ's project code style. Is there a code style guide that I missed?

[fpapon]

@georgecao thanks for the unit tests!
Can you squash the commit please?

[bdemers]

@georgecao nope, I was just removing the white space to help reduce the diff to the lines needed. It helps when backporting too.

Thanks for the patch!!

[georgecao]

@georgecao thanks for the unit tests!

Can you squash the commit please?

Done.

[fpapon]

@georgecao Thank you very much for your contribution!

[georgecao]

Looks like CI builds are not stable, logInAndRememberMe fails occasionally. @fpapon @bdemers

[fpapon]

Looks like CI builds are not stable, logInAndRememberMe fails occasionally. @fpapon @bdemers

Yes it's a know issue, don't worry it's not related to your PR.