Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-884] use plugin version from parent #365

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Jun 29, 2022

https://issues.apache.org/jira/browse/SHIRO-884

I just removed the plugin version to simply inherit from parent plugin management

but I don't see why this doc profile is used given the work is already done by the apache-release profile: another fix would basically to fully remove this profile

@fpapon fpapon self-requested a review June 29, 2022 07:02
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@hboutemy thanks!

@fpapon fpapon merged commit 853b2a2 into apache:main Jun 29, 2022
@hboutemy hboutemy deleted the SHIRO-884 branch January 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants