Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-871] Apply principalSuffix only when username does NOT already contain the suffix #350

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[SHIRO-871] Apply principalSuffix only when username does NOT already contain the suffix #350

merged 1 commit into from
Jun 23, 2022

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Mar 18, 2022 •
edited
Loading

Fixes: SHIRO-871
@manticore-projects
Copy link

Thanks Brian,

unfortunately the patch needs a fix:

if (principalSuffix != null && !userPrincipalName.toLowerCase().endsWith( principalSuffix.toLowerCase() ) ) {

Apologies for working sloppy.
@bdemers
Copy link
Member Author

bdemers commented Mar 21, 2022

Thanks @manticore-projects! I caught that one, take a look at the PR, I tweaked the original patch a little and added a couple of tests. Any feedback welcome!
@fpapon fpapon changed the title Apply principalSuffix only when username does NOT already contain the suffix Jun 6, 2022
@bdemers bdemers merged commit 017d8e0 into main Jun 23, 2022
@bdemers bdemers deleted the SHIRO-871 branch June 23, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@bdemers @manticore-projects