Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-842] log4j update #335

Merged
merged 2 commits into from
Jan 27, 2022
Merged

[SHIRO-842] log4j update #335

merged 2 commits into from
Jan 27, 2022

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jan 21, 2022

  • Fixes SHIRO-842
  • removes all log4j1 usages (test usages)
  • replaces "test if logged" with LoggerContextRule

TBD:

  • Need to remove the code cleanup from my IDE
  • Replace all log4j.properties with log4j2.xml

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

core/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Feel free to ignore my dependency scope comment, that's something we can clean up in bulk after (and include all of the other test dependencies at the same time)

@bmarwell bmarwell marked this pull request as ready for review January 21, 2022 21:43
@bmarwell bmarwell force-pushed the SHIRO-842_log4j_update branch 2 times, most recently from 035ac8c to d0214fb Compare January 24, 2022 09:47
@fpapon fpapon self-requested a review January 24, 2022 10:41
@fpapon fpapon merged commit 8eb2218 into main Jan 27, 2022
@fpapon fpapon deleted the SHIRO-842_log4j_update branch January 27, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants