Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container ITs: OpenLiberty and Meecrowave #315

Merged
merged 3 commits into from
Oct 23, 2021
Merged

Container ITs: OpenLiberty and Meecrowave #315

merged 3 commits into from
Oct 23, 2021

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Aug 1, 2021

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell requested a review from bdemers August 1, 2021 20:23
@bmarwell bmarwell changed the title Meecrowave it Aug 2, 2021
@fpapon
Copy link
Member

fpapon commented Aug 4, 2021

Some JDK modules seems to be missing starting Java 16 on CI:

Error:  Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.529 s <<< FAILURE! - in org.apache.shiro.testing.jaxrs.openliberty.OpenLibertyIT
Error:  testGetUsersBasicAuthenticated  Time elapsed: 0.136 s  <<< ERROR!
java.lang.reflect.InaccessibleObjectException: Unable to make field private static volatile java.net.Authenticator java.net.Authenticator.theAuthenticator accessible: module java.base does not "opens java.net" to unnamed module @2a79781f
@bmarwell
Copy link
Contributor Author

bmarwell commented Aug 4, 2021

Some JDK modules seems to be missing starting Java 16 on CI:

Probably blocked by this one: OpenLiberty/open-liberty#14096

@fpapon
Copy link
Member

fpapon commented Aug 4, 2021

Some JDK modules seems to be missing starting Java 16 on CI:

Probably blocked by this one: OpenLiberty/open-liberty#14096

Ok, let's wait for the bugfix

Comment on lines +143 to +144
<surefire.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</surefire.argLine>
<failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this b/c of surefire (not b/c of Liberty, actually).

@bmarwell bmarwell marked this pull request as ready for review October 21, 2021 10:29
@bmarwell bmarwell requested a review from fpapon October 21, 2021 10:30
@bmarwell bmarwell merged commit b637c46 into apache:main Oct 23, 2021
@bmarwell bmarwell deleted the meecrowave-it branch October 23, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants