Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-818] Return other status codes for AuthorizationExceptions. #303

Merged
merged 1 commit into from
May 21, 2021
Merged

[SHIRO-818] Return other status codes for AuthorizationExceptions. #303

merged 1 commit into from
May 21, 2021

Conversation

bmarwell
Copy link
Contributor

  • do not map the class AuthorizationException itself (for now).
    This exception is only thrown from the aop support (which might need to be changed to a subclass)
    and from Jdbc/Ldap-Realms. But those should lead to internal server errors, as
    internal code has thrown an exception.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue SHIRO-818 filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell requested review from bdemers and fpapon May 20, 2021 10:16
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 - shorten the test using Apache CXF.
 - Log exceptions.
 - do not map the class AuthorizationException itself (for now).
   This exception is only thrown from the aop support (which might need to be changed to a subclass)
   and from Jdbc/Ldap-Realms. But those should lead to internal server errors, as
   internal code has thrown an exception.

Co-authored-by: Romain Manni-Bucau <rmannibucau@apache.org>
@bmarwell bmarwell requested a review from bdemers May 20, 2021 19:39
@bmarwell
Copy link
Contributor Author

Changes:

  • Added logging to Exception Mappers
  • Reduced the test case a little by using CXF Frontend (thanks to Romain)
  • Removed an exception subclass
@bmarwell bmarwell merged commit a949178 into apache:main May 21, 2021
@bmarwell bmarwell deleted the fix-jaxrs-exceptionmapper branch May 21, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants