Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update setup-jdk / maven action. #301

Merged
merged 2 commits into from
Jun 25, 2021
Merged

update setup-jdk / maven action. #301

merged 2 commits into from
Jun 25, 2021

Conversation

bmarwell
Copy link
Contributor

No description provided.

fpapon
fpapon approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kriegaex
Copy link
Contributor

kriegaex commented Jun 25, 2021 •
edited
Loading

@bmarwell, a few days ago you asked me about the build failures. Today, I cloned Shiro and checked out your PR branch. I could reproduce the problem here. Then I made a few POM changes, not expecting the build result to change, it was simply meant to be a clean-up. But to my own surprise, my commit fixed the CI build. You might want to cherry-pick it from my fork. I have not checked which part fixed it, but maybe it was the upgrade from AspectJ 1.9.4 to 1.9.7.M3.

A few hours ago, AspectJ 1.9.7 was released, as you Dependabot already seem to have has noticed, judging from the new PR in AspectJ Maven. I am also going to upgrade my fork and release a final version 1.13 after 1.13.M3. Feel free to upgrade as soon as it is available, then also upgrading the AspectJ version from my commit.
@bmarwell
Copy link
Contributor Author

@kriegaex thanks a bunch!!! I think I saw that somewhere already, but I just could not remember where. But now we have proof and something to cherry-pick from. Thanks! :)
bmarwell and others added 2 commits June 25, 2021 07:29
@bmarwell
update setup-jdk / maven action.
a5da6e8 
 - start with single java8 build. Only build others if first did not fail.
 - allow manual builds for branches
 - do not cache own artifacts
 - refine matrix (exclude some slow runners)
 - update aspectj-tools to 1.9.7.M3
@kriegaex @bmarwell
Bump AspectJ to 1.9.7.M3, centralise AspectJ Maven config
fd4ca86
@bmarwell bmarwell merged commit 69132cd into apache:main Jun 25, 2021
@bmarwell bmarwell deleted the update-setup-jdk branch June 25, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@bmarwell @kriegaex @bdemers @fpapon