Bugfix, fixed Scanner issue

[pitjazz]

Following this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
  where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[bdemers]

Thanks @pitjazz!

It's not clear what this PR fixes, can you update the PR title with a specific fix,
And add detail to the commit/PR description

Adding a test would be great too!

[bdemers]

Suggested change

	} catch (Exception e) {
	if (log.isWarnEnabled()) {
	String msg = "Unable to fetch next line, Scanner stream corrupted.";
	log.warn(msg, e);
	}
	}

I'm guessing just removing the catch block should remove the sonar error.

[pitjazz]

I removed the catch block, updated the pull request. What I want to do is just close the scanner and catch is not needed for that.

I also removed the unit test. There is no need to test how scanner reads the nextLine, because reading of users and roles are already tested in TextConfigurationRealmTest. Perhaps closing the scanner could be tested, but IMHO it's not relevant.

[bdemers]

@pitjazz actually, reopened the PR with a suggestion, as I think that is what you are trying to resolve

[bdemers]

Code looks good now!

Can you fix the commit message (some of it is no longer valid)

[pitjazz]

Code looks good now!

Can you fix the commit message (some of it is no longer valid)

Commit message fixed.

[bdemers]

Thanks @pitjazz