Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-797] Shiro 1.7.0 is lower than using springboot version 2.0.7 dependency error #263

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

dngzs
Copy link
Contributor

@dngzs dngzs commented Nov 4, 2020

hotfix Springboot in versions lower than 2.0.7 does not have trim classname, one more space causes an error

https://issues.apache.org/jira/projects/SHIRO/issues/SHIRO-797?filter=allopenissues

@fpapon fpapon changed the title hotfix Shiro 1.7.0 is lower than using springboot version 2.0.7 dependency error Nov 9, 2020
@fpapon fpapon self-requested a review November 10, 2020 06:54
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header is missing in test classes.
@bdemers can you add them?

@bdemers
Copy link
Member

bdemers commented Nov 10, 2020

License header is missing in test classes.
@bdemers can you add them?

🤦 on it

@fpapon fpapon self-requested a review November 10, 2020 16:08
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdemers all good 👍

@fpapon fpapon merged commit c0ff831 into apache:master Nov 10, 2020
@tonypig93
Copy link

@fpapon so when will we get a new release for this issue?

@fpapon
Copy link
Member

fpapon commented Nov 16, 2020

@tonypig93 I will check the 1.7.1 on Jira to see when we can cut the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants