Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-398] - Renamed the variable interval to sessionValidationInterval #245

Merged
merged 1 commit into from
Jul 26, 2020
Merged

[SHIRO-398] - Renamed the variable interval to sessionValidationInterval #245

merged 1 commit into from
Jul 26, 2020

Conversation

vgaur
Copy link

@vgaur vgaur commented Jul 25, 2020

Closes SHIRO-398.

Refactored the variable name to be consistent across implementations.
bmarwell
bmarwell approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@fpapon fpapon self-requested a review July 26, 2020 12:45
fpapon
fpapon approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!
@fpapon fpapon merged commit b294b30 into apache:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@vgaur @bmarwell @fpapon