Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-679] Shiro modules have split packages #236

Merged
merged 1 commit into from
May 13, 2020
Merged

[SHIRO-679] Shiro modules have split packages #236

merged 1 commit into from
May 13, 2020

Conversation

fpapon
Copy link
Member

@fpapon fpapon commented May 12, 2020

Modules

  • config/ogdl:

    • create package org.apache.shiro.config.ogdl and move everything into

  • core:

    • rename package config to ini (only deprecated classes into) to avoid conflict with config-core module package

  • crypto:

    • cipher: create package org.apache.shiro.crypto.cipher and move everything into

  • lang:

    • create package org.apache.shiro.lang and move everyting into

  • support/feature:

    • redefine shiro-core feature with all needed bundles

Global

  • export-package only provided by the bundle, avoid using org.apache.shiro*

Tested on Apache Karaf 4.2.8
bdemers
bdemers approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
I only took a quick pass through, but this is great.

As a bonus, it makes it easier to see what else is left in "core" that might need to be moved around (ini, jndi, ldap), but that is a topic for another thread :)
@bmarwell bmarwell mentioned this pull request May 12, 2020
Merged
@bmarwell bmarwell marked this pull request as ready for review May 12, 2020 15:21
bmarwell
bmarwell approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for taking care of this!

Browsed through it twice or thrice, haven't picked up anything suspicious
@bmarwell bmarwell marked this pull request as draft May 12, 2020 15:22
@steinarb
Copy link
Contributor

LGTM
@fpapon fpapon marked this pull request as ready for review May 12, 2020 19:46
jbonofre
jbonofre approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me as a first step to cleanup.
@fpapon
Copy link
Member Author

fpapon commented May 13, 2020

Thanks guys for the review, I merge it and we can move forward on 2.0.0!
@fpapon fpapon merged commit 323698e into apache:master May 13, 2020
@fpapon fpapon mentioned this pull request May 13, 2020
Closed
@fpapon fpapon deleted the SHIRO-679 branch June 13, 2020 13:32
@pierre pierre mentioned this pull request Aug 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants
@fpapon @steinarb @bdemers @jbonofre @bmarwell