New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-773] update groovy for JDK14 builds. #231

Merged

fpapon merged 1 commit into apache:master from bmarwell:SHIRO-773-groovy

May 9, 2020

Contributor

bmarwell commented May 9, 2020

Updated groovy to 3.x. 2.5.10 would have been enough, but here were no failing tests due to the use of the new major version, so why not just update?
Added an oversight from SHIRO-736 where it was found out that the GCM padding cipher is just an alias for the non-padding one. It was only added for block mode ciphers. This is needed to get Shiro compiling with JDK14.


          [SHIRO-773] update groovy for JDK14 builds.

98dbd5c

fpapon self-requested a review

May 9, 2020 17:24

fpapon approved these changes

View reviewed changes

Member

fpapon left a comment

LGTM

fpapon merged commit 72c6b16 into apache:master

bmarwell deleted the SHIRO-773-groovy branch

May 10, 2020 05:54

bdemers added a commit that referenced this pull request


          Correct padding of streaming cipher for Java 14

06da4a7

Update groovy version (uses an ASM version that supports java 14)

Pre Java 14 "AES/GCM/PKCS5Padding" was basically an alias to "AES/GCM/NoPadding" this is no longer the case
https://www.oracle.com/java/technologies/javase/14-relnote-issues.html#JDK-8180392

back-port: #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment