Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-771] Add additional build jobs with various JDKs. #227

Merged
merged 1 commit into from
May 11, 2020
Merged

[SHIRO-771] Add additional build jobs with various JDKs. #227

merged 1 commit into from
May 11, 2020

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 8, 2020

No description provided.

@bmarwell
Copy link
Contributor Author

bmarwell commented May 8, 2020

Build fails because of the api compat plugin.
@fpapon fpapon self-requested a review May 8, 2020 19:47
@bmarwell bmarwell marked this pull request as draft May 9, 2020 12:22
@fpapon
Copy link
Member

fpapon commented May 9, 2020

I think we could add some jdk8 jobs
@fpapon
Copy link
Member

fpapon commented May 11, 2020

@bmhm is this still a draft or it's ready to merge?
@bmarwell bmarwell marked this pull request as ready for review May 11, 2020 08:08
fpapon
fpapon approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!
@fpapon fpapon merged commit 227937f into apache:master May 11, 2020
@bmarwell bmarwell deleted the SHIRO-771-travis-builds branch May 11, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@bmarwell @fpapon