Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-770] Remove base64 implementation, keep UTF-8 codec by default. #224

Merged
merged 1 commit into from
May 7, 2020
Merged

[SHIRO-770] Remove base64 implementation, keep UTF-8 codec by default. #224

merged 1 commit into from
May 7, 2020

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 6, 2020

For v2.0.0, we probably do not want to maintain our own Base64 implementation.

Still, the shiro implementation defaulted to UTF-8 for decoding strings, which seems to be a sane default.

However, the CryptoException became unreachable from the Base64 class. As this is not cryptography anyway, I decided to replace it with the IllegalArgumentException thrown by java.util.Base64's methods.

@fpapon
Copy link
Member

fpapon commented May 6, 2020

Build is broken because of jacip maven plugin for api incompatibility but it's normal as we move on 2.0.0 and we want to broke this.
I will deactivate this.

@bdemers
Copy link
Member

bdemers commented May 6, 2020

Build is broken because of jacip maven plugin for api incompatibility but it's normal as we move on 2.0.0 and we want to broke this.
I will deactivate this.

+1, the config probably needs to change as a major version change in the pom should allow for breaking API changes.
But, for exactly that same reason, we don't need to be running japicmp right now anyway.

Once we get closer to a beta for date for 2.x, we can generate a japicmp report and list out the API changes.

@bdemers
Copy link
Member

bdemers commented May 6, 2020

@bmhm great change! PRs that remove code are my favorite 😄

@fpapon
Copy link
Member

fpapon commented May 6, 2020

retest this please

@fpapon
Copy link
Member

fpapon commented May 6, 2020

@bmhm can you create a Jira for this issue?

@bmarwell bmarwell changed the title (doc) Remove base64 implementation, keep UTF-8 codec by default. May 7, 2020
@bmarwell
Copy link
Contributor Author

bmarwell commented May 7, 2020

@bmhm can you create a Jira for this issue?

SHIRO-770 - https://issues.apache.org/jira/browse/SHIRO-770

@fpapon fpapon self-requested a review May 7, 2020 14:46
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpapon fpapon merged commit 13806fc into apache:master May 7, 2020
@bmarwell bmarwell deleted the base64-away2 branch May 9, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants