Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1383] bugfix(jax-rs): unauthenticated vs. authorized HTTP response codes we… #1487

Merged
merged 1 commit into from
May 21, 2024

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented May 20, 2024

…re flipped - fixed

fixes #1383
fixes #1384

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak added this to the 2.0.1 milestone May 20, 2024
@lprimak lprimak added java Pull requests that update Java code jakartaee Jakarta EE labels May 20, 2024
@lprimak lprimak requested review from fpapon and bmarwell May 20, 2024 23:25
@lprimak lprimak self-assigned this May 20, 2024
@lprimak lprimak merged commit 7f7743d into apache:main May 21, 2024
22 checks passed
@lprimak lprimak deleted the jaxrs-response-flipped branch May 21, 2024 20:05
@boris-petrov
Copy link
Contributor

Great fix! There are a couple of comments that must be fixed also - in UnauthenticatedExceptionExceptionMapper 403 should be replaced with 401 and vice-versa in UnauthorizedExceptionExceptionMapper.

@lprimak
Copy link
Contributor Author

lprimak commented May 22, 2024

@boris-petrov that's a good one... fixed :)

@boris-petrov
Copy link
Contributor

Awesome! :) Now a new release please! 😄

@lprimak
Copy link
Contributor Author

lprimak commented May 22, 2024

Need @bmarwell to approve #1467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jakartaee Jakarta EE java Pull requests that update Java code
3 participants