Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1424] Add generic way to decorate SecurityManager #1429

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Apr 20, 2024

Jakarta EE module has to decorate SecurityManager since SecurityManager is designed to be customized / inherited by the user.
In order to do this, it introduced WrappedSecurityManager
Unfortunately, SecurityUtils classes would return the WrappedSecurityManager instance and there is no way to return the original customized SecurityManager as WrappedSecurityManager is not a superclass of the customized SecurityManager

This PR introduces SecurityUtils.getSecurityManager(Class<> type) to avoid casts to custom SecurityManager implementations by the user and unwraps the original if necessary

  • Added getSecurityManager(Class<> type) that returns typed / unwrapped SM, or an exception to SecurityUtils
  • Added isSecurityManagerTypeOf(Class<> type) to SecurityUtils
  • Added unwrapSecurityManager to SecurityUtils
  • Added WrappedSecurityManager interface for wrapped SecurityManager implementations
  • Made Jakarta EE module use the new interface

fixes #1424

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak self-assigned this Apr 20, 2024
@lprimak lprimak added java Pull requests that update Java code jakartaee Jakarta EE core Core Modules labels Apr 20, 2024
@lprimak lprimak added this to the 2.0.1 milestone Apr 20, 2024
@lprimak lprimak changed the title wip Apr 20, 2024
@lprimak lprimak changed the title [#1424] wip Apr 20, 2024
…yUtils.getSecurityManager() and Jakarta EE to use it
@lprimak lprimak marked this pull request as ready for review April 21, 2024 05:05
@lprimak lprimak changed the title [#1424] Add generic way to wrap SecurityManager Apr 21, 2024
@lprimak lprimak merged commit 7db7bfe into apache:main Apr 26, 2024
22 checks passed
@lprimak lprimak deleted the add-wrapped-interface branch April 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Modules jakartaee Jakarta EE java Pull requests that update Java code
1 participant