Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1117] fix missing osgi headers #1118

Merged
merged 1 commit into from
Nov 11, 2023
Merged

[#1117] fix missing osgi headers #1118

merged 1 commit into from
Nov 11, 2023

Conversation

jherkel
Copy link
Contributor

@jherkel jherkel commented Oct 17, 2023

fixes #1117

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak requested a review from bmarwell October 17, 2023 19:31
@lprimak lprimak added this to the 2.0 milestone Oct 17, 2023
@fpapon fpapon self-requested a review October 18, 2023 07:11
@fpapon
Copy link
Member

fpapon commented Oct 18, 2023

@jherkel thank you for your contribution! Let me test it on a fresh Karaf.
I'll keep you posted.

@fpapon fpapon self-assigned this Oct 18, 2023
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I fixed the Karaf features in another PR.

@fpapon
Copy link
Member

fpapon commented Nov 11, 2023

supercedes by #1158

@fpapon fpapon merged commit c389e64 into apache:main Nov 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants