Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing JPMS module names leading to warning for users #896

Closed
lprimak opened this issue Jun 3, 2023 · 0 comments · Fixed by #961
Closed

Missing JPMS module names leading to warning for users #896

lprimak opened this issue Jun 3, 2023 · 0 comments · Fixed by #961
Assignees
Labels
Milestone

Comments

@lprimak
Copy link
Contributor

lprimak commented Jun 3, 2023

Neither JPMS module-info nor automatic module manifest entries are present in the artifacts.
This causes nasty warnings from maven compiler plugin when using Shiro as a dependenc.

Either module-info or manifest entry should be added to all JAR artifacts

I have tried doing this, but the automated way doesn't work because the artifactIds have dashes in them instead of dots, which is disallowed by JPMS
Also tried maven-helper plugin to transform dashes to dots, but it didn't work

NOTE: If using Java modules with the previous alphas, the module names have changed (example: shiro.core -> org.apache.shiro.core)

@lprimak lprimak added this to the 2.0 milestone Jun 3, 2023
@lprimak lprimak changed the title Missing JPMS module names Jun 3, 2023
@lprimak lprimak added the core Core Modules label Jun 7, 2023
@lprimak lprimak self-assigned this Jun 29, 2023
lprimak added a commit that referenced this issue Jun 30, 2023
[GH-896] Added JPMS module names to JAR manifests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant