Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize password rules, add special characters '#' and '.' #309

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

liusishan
Copy link
Contributor

  • fix password rules, add special characters # and .

password rule is Minimum length of 8, including upper and lower case letters, numbers and special characters

The password eg: ShenYu#=123 ShenYu=.123 can not pass the password rule now due the rule think #. are not special characters.

But the characters #. are password special characters that we use frequently. User can not find what the problem when them use this characters to change password.
before:
1
after:
2

This is my inaugural pull request (PR) submission. I used #287 as a reference for the formatting. If there are any areas that require refinement, I am committed to making prompt adjustments.

@dengliming dengliming added the type: enhancement New feature or request label Aug 11, 2023
@li-keguo
Copy link
Member

@li-keguo li-keguo merged commit 0b0983f into apache:master Aug 14, 2023
5 checks passed
@liusishan
Copy link
Contributor Author

hi ~You need to modify this file synchronously to really solve this problem https://github.com/apache/shenyu/blob/master/shenyu-admin/src/main/java/org/apache/shenyu/admin/model/constant/RegConstant.java

Sure,

Thanks for bringing this up. I've already made the required synchronous modifications to the file. You can check out the changes in this Pull Request: apache/shenyu#4977

Let me know if there's anything else. Appreciate your help!

@li-keguo
Copy link
Member

hi ~You need to modify this file synchronously to really solve this problem https://github.com/apache/shenyu/blob/master/shenyu-admin/src/main/java/org/apache/shenyu/admin/model/constant/RegConstant.java

Sure,

Thanks for bringing this up. I've already made the required synchronous modifications to the file. You can check out the changes in this Pull Request: apache/shenyu#4977

Let me know if there's anything else. Appreciate your help!

👌

@dengliming dengliming changed the title fix password rules, add special characters '#' and '.' Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
3 participants