Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type:fixbug]fix bug :after add paged is fail #188

Merged
merged 3 commits into from
Mar 24, 2022
Merged

[type:fixbug]fix bug :after add paged is fail #188

merged 3 commits into from
Mar 24, 2022

Conversation

li-keguo
Copy link
Member

about: apache/shenyu#3062

fix ： Pagination fails after adding or editing
@dengliming
Copy link
Member

@daiwenyu cc : )
daiwenyu
daiwenyu reviewed Mar 24, 2022
View reviewed changes
src/routes/System/PluginHandle/index.js
@@ -166,7 +166,7 @@ export default class PluginHandle extends Component {
type: "pluginHandle/fetch",
payload: {
pluginId: searchPluginId,
currentPage: {currentPage},
currentPage: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use currentPage, remove {}
daiwenyu
daiwenyu reviewed Mar 24, 2022
View reviewed changes
src/routes/System/PluginHandle/index.js
@@ -228,7 +228,7 @@ export default class PluginHandle extends Component {
type: "pluginHandle/fetch",
payload: {
pluginId: searchPluginId,
currentPage: {currentPage},
currentPage: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same too, thanks
@daiwenyu
Copy link
Contributor

@li-keguo Hi，buddy about src/routes/System/PluginHandle/index.js , I think the current page number should be kept，just remove {}, thanks
@li-keguo
Copy link
Member Author

@li-keguo Hi，buddy about src/routes/System/PluginHandle/index.js , I think the current page number should be kept，just remove {}, thanks

@daiwenyu Hi it's ok to do this,
But I encountered a bug like this before：
There are query conditions before adding, but I didn't click the query button, my page number is on the last page，
After adding, the list cannot be queried for data。
I think all add needs to be reset after adding
@li-keguo
Copy link
Member Author

e..... new condition reset too...

image
@li-keguo
Copy link
Member Author

i try to fix it，
@daiwenyu daiwenyu merged commit dee5813 into apache:master Mar 24, 2022
@li-keguo li-keguo mentioned this pull request Apr 1, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@li-keguo @dengliming @daiwenyu