SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sborya
approved these changes
Mar 6, 2019
| .getOrElse(throw new SamzaException("No offset defined for SystemStreamPartition: %s" format ssp)) | ||
|
|
||
| if(Objects.equals(upcomingOffset, startingOffset)) { | ||
| ssp2CaughtupMapping(ssp) = true |
| @@ -321,6 +323,25 @@ class TaskInstance( | |||
| } | |||
| } | |||
|
|
|||
| def initCaughtUpMapping() { | |||
There was a problem hiding this comment.
Added the comments.
lhaiesp
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the TaskInstance.checkCaughtUp() logic has a bug that if there is no incoming messages for a partition, it will not mark the ssp to be caught up. Instead, it should mark ssp to be caught up if the starting offset is already the upcoming offset for a ssp, meaning it has consumed all the messages in this partition and waiting for the future incoming messages. This indicates the ssp is fully caught up.