SAMZA-1998: Table API refactoring #807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed TableSpec - Consolidated configuration for tables to table descriptors - Refactored constructor so that only local table would require serde's - Removed table provider for RocksDB- and in-memory tables, and added LocalTableProvider - Various refactoring for unit tests
prateekm
requested changes
Nov 19, 2018
samza-api/src/main/java/org/apache/samza/table/descriptors/BaseTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/BaseTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/CachingTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/LocalTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/LocalTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/table/TableConfigGenerator.java
Show resolved
Hide resolved
prateekm
approved these changes
Nov 20, 2018
samza-api/src/main/java/org/apache/samza/table/descriptors/CachingTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/BaseTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/LocalTableDescriptor.java
Outdated
Show resolved
Hide resolved
samza-api/src/main/java/org/apache/samza/table/descriptors/TableDescriptor.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/table/TableManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table API refactoring
- Removed TableSpec
- Consolidated configuration generation for tables to table descriptors
- Refactored constructor so that only local table would require serde's
- Removed table provider for RocksDB- and in-memory tables, and added LocalTableProvider
- Updates to unit tests
- Various refactoring