Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8375] Add more test coverage for MqClientAdminImpl #8376

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Jul 8, 2024

Fixes #8375 .

before:
image
after:
image

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.24%. Comparing base (5dc0c6a) to head (b50621a).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8376      +/-   ##
=============================================
+ Coverage      43.99%   44.24%   +0.24%     
- Complexity     10669    10732      +63     
=============================================
  Files           1274     1274              
  Lines          88939    88939              
  Branches       11432    11432              
=============================================
+ Hits           39130    39352     +222     
+ Misses         44841    44618     -223     
- Partials        4968     4969       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 67ddc1d into apache:develop Jul 10, 2024
10 checks passed
@yx9o yx9o deleted the dev-8375 branch July 10, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants