Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add iter->status() check for loop iterators #2395

Merged
merged 5 commits into from
Jul 7, 2024
Merged

feat: add iter->status() check for loop iterators #2395

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f887cfc
add `iter->status()` for loop iterators
LindaSummer Jul 5, 2024
cc4f85d
use `err_str` rather than recalling `status::ToString()`
LindaSummer Jul 6, 2024
9c41416
Merge branch 'unstable' into feature/iterator_valid_check
git-hulk Jul 6, 2024
20c216c
Merge branch 'unstable' into feature/iterator_valid_check
LindaSummer Jul 7, 2024
373c2ac
Merge branch 'unstable' into feature/iterator_valid_check
PragmaTwice Jul 7, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use err_str rather than recalling status::ToString()
  • Loading branch information
@LindaSummer
LindaSummer committed Jul 6, 2024
commit cc4f85d947c8f4200f02d6e5b8f3c1076ee63c9e
2 changes: 1 addition & 1 deletion src/cluster/slot_migrate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ Status SlotMigrator::sendSnapshotByCmd() {
if (auto s = iter->status(); !s.ok()) {
auto err_str = s.ToString();
LOG(ERROR) << "[migrate] Failed to iterate keys of slot " << slot << ": " << err_str;
return {Status::NotOK, fmt::format("failed to iterate keys of slot {}: {}", slot, s.ToString())};
return {Status::NotOK, fmt::format("failed to iterate keys of slot {}: {}", slot, err_str)};
}

// It's necessary to send commands that are still in the pipeline since the final pipeline may not be sent
Expand Down
Loading