KARAF-7829 Override org.slf4j to 2.0.12 #1851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
approved these changes
Jun 26, 2024
PeterSuna
force-pushed
the
main_KARAF-7829
branch
2 times, most recently
from
2b61099
to
6a57489
Compare
Override transitive dependency version for org.slf4j from 1.7.32 and 1.7.35 to 2.0.12 as defined in the Karaf project. Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
PeterSuna
force-pushed
the
main_KARAF-7829
branch
from
6a57489
to
3010797
Compare
|
Just a note: this PR doesn't actually fix the problem described in KARAF-7829. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override transitive dependency version for
org.slf4jfrom 1.7.32 and 1.7.35 to 2.0.12 as defined in Karaf BOM project.This issue arose after bumping slf4j to 2.0.12 in this commit:
03354d2#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R324
However, some transitive dependencies still remain at version 1.7.32 and 1.7.35. See the
mvn dependency:treeoutput:[INFO] --- dependency:3.6.1:tree (default-cli) @
manual---[INFO] org.apache.karaf:manual:bundle:4.5.0-SNAPSHOT
[INFO] +- org.apache.karaf.subsystem:org.apache.karaf.subsystem.core:jar:4.5.0-SNAPSHOT:provided
[INFO] | +- org.apache.karaf.features:org.apache.karaf.features.core:jar:4.5.0-SNAPSHOT:provided
[INFO] | | +- org.ops4j.pax.url:pax-url-aether:jar:2.6.14:provided
[INFO] | | | -
org.slf4j:jcl-over-slf4j:jar:1.7.32:provided[INFO] --- dependency:3.6.1:tree (default-cli) @
karaf-graphql-example-commands---[INFO] org.apache.karaf.examples:karaf-graphql-example-commands:bundle:4.5.0-SNAPSHOT
[INFO] +- org.apache.karaf.shell:org.apache.karaf.shell.core:jar:4.5.0-SNAPSHOT:compile
[INFO] | +- org.jline:jline:jar:3.21.0:compile
[INFO] | +- org.apache.karaf.jaas:org.apache.karaf.jaas.boot:jar:4.5.0-SNAPSHOT:compile
[INFO] | - org.apache.sshd:sshd-osgi:jar:2.12.1:compile
[INFO] | -
org.slf4j:jcl-over-slf4j:jar:1.7.32:compile[INFO] +- com.graphql-java:graphql-java:jar:19.2:compile
[INFO] | +- com.graphql-java:java-dataloader:jar:3.2.0:compile
[INFO] | +- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] | -
org.slf4j:slf4j-api:jar:1.7.35:compile[INFO] --- dependency:3.6.1:tree (default-cli) @
karaf-graphql-example-api---[INFO] org.apache.karaf.examples:karaf-graphql-example-api:bundle:4.5.0-SNAPSHOT
[INFO] +- com.graphql-java:graphql-java:jar:19.2:compile
[INFO] | +- com.graphql-java:java-dataloader:jar:3.2.0:compile
[INFO] | +- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] | -
org.slf4j:slf4j-api:jar:1.7.35:compile[INFO] --- dependency:3.6.1:tree (default-cli) @
karaf-graphql-example-scr-servlet---[INFO] org.apache.karaf.examples:karaf-graphql-example-scr-servlet:bundle:4.5.0-SNAPSHOT
[INFO] +- org.osgi:org.osgi.service.component.annotations:jar:1.4.0:provided
[INFO] +- com.graphql-java:graphql-java:jar:19.2:compile
[INFO] | +- com.graphql-java:java-dataloader:jar:3.2.0:compile
[INFO] | +- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] | -
org.slf4j:slf4j-api:jar:1.7.35:compile[INFO] --- dependency:3.6.1:tree (default-cli) @
karaf-graphql-example-core---[INFO] org.apache.karaf.examples:karaf-graphql-example-core:bundle:4.5.0-SNAPSHOT
[INFO] +- org.apache.karaf.examples:karaf-graphql-example-api🫙4.5.0-SNAPSHOT:compile
[INFO] +- org.osgi:org.osgi.service.component.annotations:jar:1.4.0:provided
[INFO] +- com.graphql-java:graphql-java:jar:19.2:compile
[INFO] | +- com.graphql-java:java-dataloader:jar:3.2.0:compile
[INFO] | +- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] | -
org.slf4j:slf4j-api:jar:1.7.35:compile[INFO] --- dependency:3.6.1:tree (default-cli) @
karaf-graphql-example-websocket---[INFO] org.apache.karaf.examples:karaf-graphql-example-websocket:bundle:4.5.0-SNAPSHOT
[INFO] +- org.eclipse.jetty.websocket:websocket-servlet:jar:9.4.54.v20240208:provided
[INFO] | +- org.eclipse.jetty.websocket:websocket-api:jar:9.4.54.v20240208:provided
[INFO] | - javax.servlet:javax.servlet-api:jar:3.1.0:provided
[INFO] +- org.apache.karaf.examples:karaf-graphql-example-api🫙4.5.0-SNAPSHOT:compile
[INFO] | - com.graphql-java:graphql-java:jar:19.2:compile
[INFO] | +- com.graphql-java:java-dataloader:jar:3.2.0:compile
[INFO] | +- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] | -
org.slf4j:slf4j-api:jar:1.7.35:compileThis can be fixed by specifying the correct version in dependency management.