Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Move related getters to RemoteLogManagerConfig #16538

Merged
merged 1 commit into from
Jul 7, 2024
Merged

MINOR: Move related getters to RemoteLogManagerConfig #16538

merged 1 commit into from
Jul 7, 2024
+18 −14

Conversation

brandboat
Copy link
Member

there are two RemoteLogManagerConfig-related getters logLocalRetentionBytes logLocalRetentionMs which still remain in KafkaConfig, this pr move them to RemoteLogManagerConfig.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@brandboat
Copy link
Member Author

gentle ping @chia7712 , @kamalcph. Could you take a look when you are available ? Thanks
chia7712
chia7712 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@chia7712 chia7712 merged commit d45596a into apache:trunk Jul 7, 2024
1 check failed
@brandboat brandboat deleted the minor/move-config-to-remote-log-manager-config branch July 8, 2024 00:16
@kamalcph
Copy link
Collaborator

kamalcph commented Jul 8, 2024

LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@brandboat @kamalcph @chia7712