Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raster processing #884

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Raster processing #884

wants to merge 7 commits into from

Conversation

bchapuis
Copy link
Member

@bchapuis bchapuis commented Jul 1, 2024

This pull request introduces:

  • A hillshade algorithm (raster to raster)
  • A contour algorithm (raster to vector)
  • A port of the martini algorithm (raster to 3d mesh)
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 2, 2024
View reviewed changes
baremaps-raster/src/test/java/org/apache/baremaps/raster/contour/IsoLinesTest.java Fixed Show fixed Hide fixed
baremaps-raster/src/test/java/org/apache/baremaps/raster/hillshade/HillShadeTest.java Fixed Show fixed Hide fixed
baremaps-raster/src/main/java/org/apache/baremaps/raster/contour/IsoLines.java Fixed Show fixed Hide fixed
baremaps-cli/src/main/java/org/apache/baremaps/cli/raster/HillShade.java
}
}

public class HillShadeTileResource {

Check notice

Code scanning / CodeQL

Inner class could be static Note

HillShadeTileResource should be made static, since the enclosing instance is not used.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 23, 2024
View reviewed changes
baremaps-raster/src/test/java/org/apache/baremaps/raster/elevation/IsoLinesTest.java Fixed Show fixed Hide fixed
baremaps-raster/src/test/java/org/apache/baremaps/raster/elevation/HillShadeRenderer.java

// Add listeners
ChangeListener listener = new ChangeListener() {
public void stateChanged(ChangeEvent e) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ChangeListener.stateChanged
Loading
; it is advisable to add an Override annotation.
@bchapuis bchapuis force-pushed the raster-processing branch 2 times, most recently from 7b130a1 to e61b8a5 Compare July 23, 2024 15:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 23, 2024
View reviewed changes
baremaps-raster/src/test/java/org/apache/baremaps/raster/elevation/IsoLinesTest.java
import org.locationtech.jts.io.ParseException;
import org.locationtech.jts.io.WKTReader;

class IsoLinesTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note

Unused class: IsoLinesTest is not referenced within this codebase. If not used as an external API it should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@bchapuis