Kerberos #527
Draft
Kerberos #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Aside from changes mentioned below, you need to do the following things before this pull request can be accepted:
- Create a Jira account and open a new Jira tickets for this issue.
- Tag your pull request and commit messages with the ticket name.
See the following links:
https://guacamole.apache.org/open-source/
https://issues.apache.org/jira/browse/GUACAMOLE/
src/guacd-docker/krb5.conf
Outdated
Comment on lines
1
to
16
| [libdefaults] | ||
| default_realm = PROCYON.COM | ||
| dns_lookup_kdc = true | ||
| dns_lookup_realm = true | ||
|
|
||
| [realms] | ||
| PROCYON.COM = { | ||
| kdc = cez-private.procyon.com | ||
| admin_server = cez-private.procyon.com | ||
| master_kdc = cez-private.procyon.com | ||
| default_domain = procyon.com | ||
| } | ||
|
|
||
| [domain_realm] | ||
| .procyon.com = PROCYON.COM | ||
| procyon.com = PROCYON.COM |
There was a problem hiding this comment.
I think this file should be removed from the commit - this looks like something internal to your configuration. I'm not sure that we should provide a template for this - maybe just document instructions for it.
Dockerfile
Outdated
| @@ -186,6 +203,7 @@ ARG UID=1000 | |||
| ARG GID=10001 | |||
| RUN groupadd --gid $GID guacd | |||
| RUN useradd --system --create-home --shell /sbin/nologin --uid $UID --gid $GID guacd | |||
| COPY ./src/guacd-docker/krb5.conf /etc/krb5.conf | |||
There was a problem hiding this comment.
I'm not sure we should provide this - maybe just document the instructions for it.
latest alpine doesn't work - fixing to 3.18.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.