Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.20] [FLINK-35657][runtime-web] use parseFloat for metric value #25047

Open
wants to merge 2 commits into
base: release-1.20
Choose a base branch
from

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Jul 8, 2024

What is the purpose of the change

master branch PR: #24964.

Flink UI always shows float metric value as int/long. For example, outPoolUsage/inPoolUsage are always 0 or 1 at UI. That's not helpful when troubleshooting from UI.

After investigation, I found it's because we always parse the metric value via parseInt method. We should use parseFloat for it. The parseFloat can achieve what we expect because when the provided string is a integer, it'll also parsed as an integer, not float. Like this:

image

Before this change, the UI is displayed like this:
image

After this change, the UI can display float value like this:
image

Brief change log

Replacing parseInt with parseFloat to parse metric value.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
@showuon
Copy link
Contributor Author

showuon commented Jul 8, 2024

@hlteoh37 , PR to backport to 1.20. Thanks.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment