[Fix](group commit) Fix group commit wal back pressure case #37569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run p0 |
bobhan1
approved these changes
Jul 10, 2024
|
run p0 |
gavinchou
approved these changes
Jul 10, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…7569) ## Proposed changes <!--Describe your changes.--> Problem: The group commit WAL back pressure case failed. Reason: Previously, the group commit was restructured from **regular load** to **pipeline architecture load**, which improved the concurrency and speed of load. Consequently, the loads in the test case were completed much faster. The default batching time for a group commit is 10 seconds. Therefore, if all loads are finished in less than this time(10 seconds), the group commit data is not yet committed to the disk and visible, resulting in no data being returned by the final select statement. Solution: To resolve the issue, wait for one batching period (10 seconds) after completing all imports before executing the query. Plus, due to the faster speed of load, we move this case from p2 to p0.
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
## Proposed changes <!--Describe your changes.--> Problem: The group commit WAL back pressure case failed. Reason: Previously, the group commit was restructured from **regular load** to **pipeline architecture load**, which improved the concurrency and speed of load. Consequently, the loads in the test case were completed much faster. The default batching time for a group commit is 10 seconds. Therefore, if all loads are finished in less than this time(10 seconds), the group commit data is not yet committed to the disk and visible, resulting in no data being returned by the final select statement. Solution: To resolve the issue, wait for one batching period (10 seconds) after completing all imports before executing the query. Plus, due to the faster speed of load, we move this case from p2 to p0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The group commit WAL back pressure case failed.
Reason: Previously, the group commit was restructured from regular load to pipeline architecture load, which improved the concurrency and speed of load. Consequently, the loads in the test case were completed much faster. The default batching time for a group commit is 10 seconds. Therefore, if all loads are finished in less than this time(10 seconds), the group commit data is not yet committed to the disk and visible, resulting in no data being returned by the final select statement.
Solution: To resolve the issue, wait for one batching period (10 seconds) after completing all imports before executing the query.
Plus, due to the faster speed of load, we move this case from p2 to p0.