Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change array_agg to return null on no input rather than empty list #11299

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Change array_agg to return null on no input rather than empty list #11299

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8e67fcc
change array agg semantic for empty result
jayzhan211 Jul 6, 2024
13aaf09
return null
jayzhan211 Jul 6, 2024
8d57ae8
fix test
jayzhan211 Jul 6, 2024
b4747a4
fix order sensitive
jayzhan211 Jul 6, 2024
7e23569
fix test
jayzhan211 Jul 6, 2024
b4ab126
add more test
jayzhan211 Jul 7, 2024
362bd6a
Merge remote-tracking branch 'upstream/main' into array-agg-no-row
jayzhan211 Jul 8, 2024
81b8cb6
fix null
jayzhan211 Jul 9, 2024
248c0ee
fix multi-phase case
jayzhan211 Jul 9, 2024
fb8a678
add comment
jayzhan211 Jul 9, 2024
9fa5e6a
cleanup
jayzhan211 Jul 9, 2024
668a0d9
Merge remote-tracking branch 'upstream/main' into array-agg-no-row
jayzhan211 Jul 9, 2024
701b12a
fix clone
jayzhan211 Jul 9, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more test 
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
  • Loading branch information
@jayzhan211
jayzhan211 committed Jul 7, 2024
commit b4ab1265cd833a22b5ac0d6297c01b9de8c0e329
15 changes: 15 additions & 0 deletions datafusion/sqllogictest/test_files/aggregate.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,6 +2824,21 @@ select array_agg(c) from t;
----
NULL

query ?I
select array_agg(distinct a), count(1) from t;
----
NULL 0

query ?I
select array_agg(distinct b), count(1) from t;
----
NULL 0

query ?I
select array_agg(distinct b), count(1) from t;
----
NULL 0

statement ok
drop table t;

Expand Down