Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chaitin-waf): Update dep lua-resty-t1k to 1.1.5 #11391

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

xbingW
Copy link
Contributor

@xbingW xbingW commented Jul 5, 2024

fix: incorrect handling of multiple header values in HTTP/2

lua-resty-t1k released v1.1.5, which fixed the problem of multiple values ​​for the same key in the HTTP/2 request header causing detection failure.

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)
fix: incorrect handling of multiple header values in HTTP/2
@xbingW xbingW changed the title Update dep lua-resty-t1k to 1.1.5 Jul 5, 2024
@xbingW xbingW changed the title feat(chaitin-waf): Update dep lua-resty-t1k to 1.1.5 Jul 5, 2024
@xbingW xbingW dismissed shreemaan-abhishek’s stale review July 9, 2024 02:41

The merge-base changed after approval.

bzp2010
bzp2010 previously approved these changes Jul 9, 2024
@xbingW xbingW dismissed bzp2010’s stale review July 9, 2024 04:04

The merge-base changed after approval.

bzp2010
bzp2010 previously approved these changes Jul 9, 2024
@xbingW xbingW dismissed bzp2010’s stale review July 9, 2024 04:11

The merge-base changed after approval.

@moonming
Copy link
Member

@xbingW is this PR ready?

@xbingW
Copy link
Contributor Author

xbingW commented Jul 12, 2024

@xbingW is this PR ready?

yes

@moonming
Copy link
Member

@bzp2010 @shreemaan-abhishek please review again

@xbingW xbingW dismissed shreemaan-abhishek’s stale review July 12, 2024 03:32

The merge-base changed after approval.

@xbingW
Copy link
Contributor Author

xbingW commented Jul 12, 2024

https://github.com/orgs/community/discussions/58535?sort=top#discussioncomment-6233887
Maybe I have encountered this problem. Do I need to close and reopen PR?

@moonming
Copy link
Member

https://github.com/orgs/community/discussions/58535?sort=top#discussioncomment-6233887 Maybe I have encountered this problem. Do I need to close and reopen PR?

ok, you can make a try

@xbingW xbingW closed this Jul 12, 2024
@xbingW xbingW reopened this Jul 12, 2024
@xbingW
Copy link
Contributor Author

xbingW commented Jul 12, 2024

@bzp2010 @shreemaan-abhishek please review again

@bzp2010 bzp2010 merged commit 54ebd05 into apache:master Jul 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants