fix(request-id): file descriptor overflow when use request-id plugin nanoid algorithm #11060
Conversation
aikin-vip
force-pushed
the
fix-reques-id-nanoid
branch
from
76abeb0
to
80a9d1c
Compare
| @@ -51,6 +51,22 @@ local schema = { | |||
| } | |||
| }, | |||
| default = {} | |||
| }, | |||
| nanoid = { | |||
There was a problem hiding this comment.
why is this block needed when just replacing the dependency would fix the issue?
There was a problem hiding this comment.
The new dependency provides more controllable parameters and more customized functions, so parameter options are added，just like range_id
apisix/plugins/request-id.lua
Outdated
| if conf.algorithm == "nanoid" then | ||
| return nanoid.safe_simple() | ||
| return nanoid.generate(conf.nanoid.length,conf.nanoid.char_set) |
There was a problem hiding this comment.
space needed after comma
There was a problem hiding this comment.
space needed after comma
OK
| [[{ | ||
| "plugins": { | ||
| "request-id": { | ||
| "algorithm": "nanoid" |
There was a problem hiding this comment.
your PR suggests that usage method/configuration for nanoid has changed. Which means existing users will face incompatibility issues when upgrading to the newer version. We should avoid such a situation.
There was a problem hiding this comment.
I have noticed the question you raised before submitting. I have already set the initial default value in the parameters, the default parameter value will be the same as the default value generated in previous versions without modifying the parameter value. Therefore, I think the upgrade should be smooth. Is there anything missing from me?
|
|
||
| === TEST 3: hit | ||
| --- request | ||
| GET /opentracing |
There was a problem hiding this comment.
add error log and status code checks here.
shreemaan-abhishek
added
the
wait for update
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Description
Fixes (#8931)
Checklist