Reduce amount of code #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GeorgCantor ! Thanks for the PR. Since Kotlin Android Extensions are deprecated, we don't want to use Kotlin synthetics here. If you were able to migrate these to use view binding, then I'd be able to accept the PR. |
|
Ok |
nic0lette
reviewed
Apr 8, 2021
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| super.onViewCreated(view, savedInstanceState) | ||
| binding = QrSignInBinding.bind(view) |
There was a problem hiding this comment.
If you make binding a local variable then it wouldn't be nullable (so you could get rid of many of the ?s) and you wouldn't need to clear it in onDestroy()
| /** | ||
| * Sets the QR code rendered on this sign in screen. | ||
| * | ||
| * @param code The QR code to display. | ||
| */ | ||
| private fun setQrCode(url: String) { | ||
| Glide.with(this).load(url).into(qr_code) | ||
| binding?.qrCode?.let { Glide.with(this).load(url).into(it) } |
There was a problem hiding this comment.
Could you just pass the view in with the url (or, perhaps even better, just move it into onViewCreated())?
|
|
||
| /** | ||
| * This class exposes application settings | ||
| * for integration with MediaCenter in Android Automotive. | ||
| */ | ||
| class SettingsActivity : AppCompatActivity() { | ||
|
|
||
| private lateinit var binding: ActivitySettingsBinding |
There was a problem hiding this comment.
Does this need to be a member? It looks like everything is set in onCreate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced the amount of code using Kotlin Synthetic