Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add seamless transfer support #393

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

dturner
Copy link
Contributor

@dturner dturner commented Aug 13, 2020

This PR adds support for seamless transfer, allowing users to switch audio outputs using the output switcher.

@dturner dturner marked this pull request as draft August 13, 2020 20:57
@dturner dturner changed the title Add seamless transfer support Aug 13, 2020
@@ -91,6 +91,10 @@
</intent-filter>
</service>

<receiver
android:exported="true"
android:name="androidx.mediarouter.media.MediaTransferReceiver" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to figure out what seamless transfer is about. I am still not really sure. I haven't found any material what seamless transfer means, exactly. However, this is the problematic line. Adding this to the manifest makes the Cast session not start (or at least not notify us/CastSessionManager of the session start). I suspect by adding this we are overriding a behavior which makes the Cast-MediaRoute-related plumbing.

I have commented on the guidance doc to see if I can get some assistance from the Seoul team on this. I would think they are the ideal people to look into this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After asking around, from Olly who also is in the seamless transfer doc:

For seamless transfer and the part of the Cast SDK that does routing to work together properly, the Cast SDK needs updating. Before the Cast SDK can be updated, the MediaRouter AndroidX library needs updating. So there is a chain of pending things that need to happen.

So it would seem this patch cannot go in until we update the Cast SDK to the right version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for investigating. That seems to be the case.

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 18:04
@dturner dturner added this to the Next milestone Dec 4, 2020
@dturner dturner self-assigned this Dec 4, 2020
@android android deleted a comment Jun 22, 2021
@android android deleted a comment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants