Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] include LLVM commit in r26: a2684acfb61d [HWASan] use hwasan linker for Android 14+ #1907

Closed
fmayer opened this issue Jul 13, 2023 · 2 comments
Closed

[FR] include LLVM commit in r26: a2684acfb61d [HWASan] use hwasan linker for Android 14+ #1907

fmayer opened this issue Jul 13, 2023 · 2 comments
Assignees
@pirama-arumuga-nainar
Labels
enhancement
Projects
LLVM

Comments

@fmayer
Copy link

fmayer commented Jul 13, 2023 •
edited
Loading

Description

Please include https://reviews.llvm.org/rGa2684acfb61d40f441e240035d7f1ba50da637c8 in the next NDK release, this will ensure that binaries built with -fsanitize=hwaddress with API 34 and newer will work on Android U devices.
@DanAlbert DanAlbert added this to Awaiting triage in LLVM via automation Jul 13, 2023
@DanAlbert DanAlbert moved this from Awaiting triage to Awaiting update in LLVM Jul 13, 2023
@fmayer
Copy link
Author

fmayer commented Jul 13, 2023

This is already cherrypicked onto Android LLVM r487747 https://android-review.git.corp.google.com/c/toolchain/llvm_android/+/2655792
@DanAlbert DanAlbert moved this from Awaiting update to Awaiting prebuilt drop in LLVM Jul 13, 2023
@DanAlbert DanAlbert moved this from Awaiting prebuilt drop to Prebuilts submitted in LLVM Oct 5, 2023
@DanAlbert
Copy link
Member

The toolchain update that fixed this was accidentally not included in r26 RC 1 as we had intended. The fix will be in r26b.
@DanAlbert DanAlbert reopened this Oct 5, 2023
LLVM automation moved this from Prebuilts submitted to Awaiting triage Oct 5, 2023
@DanAlbert DanAlbert moved this from Awaiting triage to Prebuilts submitted in LLVM Oct 5, 2023
rooteduniverse1003 pushed a commit to rooteduniverse1003/Android-Platform-NDK that referenced this issue Nov 22, 2023
@DanAlbert
Correct the r26 LLVM changelog.
1ec485a 
We included a few changelog updates for the "d" toolchain, and even
included the new prebuilts, but neglected to actually update the NDK's
config.

The toolchain itself needs to be updated directly in the release branch
because master has already moved on for rv64 support.
https://r.android.com/2775899 does the update (but will be abandoned
once coastguard picks it up).

Bug: android/ndk#1907
Bug: android/ndk#1909
Test: None
(cherry picked from https://android-review.googlesource.com/q/commit:5e7ffb1e850ae5aac90540ea6e30320f9d61d40c)
Merged-In: Ibff877a664290979aa8488341f92f145797889a8
Change-Id: Ibff877a664290979aa8488341f92f145797889a8
rooteduniverse1003 pushed a commit to rooteduniverse1003/Android-Platform-NDK that referenced this issue Nov 22, 2023
@DanAlbert
Update LLVM to r487747d.
3784550 
The changelog update is in master. The toolchain can't be updated
there because it's already moved ahead for rv64.

Bug: android/ndk#1907
Bug: android/ndk#1909
Test: ./checkbuild.py && ./run_tests.py
(cherry picked from https://android-review.googlesource.com/q/commit:7469b730771a4c1a8dcb80ea832a462281e989ab)
Merged-In: I7f95f46b6233d7bf89821d78c5b91cde5267b3c8
Change-Id: I7f95f46b6233d7bf89821d78c5b91cde5267b3c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
3 participants
@fmayer @DanAlbert @pirama-arumuga-nainar