Make sendReportTo Doc Apply to All report* functions, Add Beacon Info… #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, Slight Flow Change Original intention here was to add what I think is a clarification about how the reporting functions send the signal back to the ad tech's servers. As I was digging through I figured a beacon would be used and I thiiink that is supported by slightly-above-cursory-inspection [here](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/interest_group/interest_group_auction_reporter.cc;l=264?q=reportResult&ss=chromium%2Fchromium%2Fsrc:content%2Fbrowser%2Finterest_group%2F). As I went to write the update I thought it made sense to add it to the paragraph I modified, but wanted it to apply across both reportResult and reportWin, and since that paragraph I think should apply to both as well, I think it makes sense to push it up the "stack" a level. Then, given the move, I changed a few things for flow. Last thing: as I was writing this PR commit, I realized this might be on the side "not a generic spec piece for any browser implementing Fledge, but still relevant for most readers of this doc"...since I don't think we talked more about that yet, I'm just gonna propose this and we can talk about what makes sense.
|
I'm not sure it's accurate to say the sendReportTo() methods implement the beacon API. While they will outlive the frame if navigated away, like beacon requests, and currently use no-cors mode, beacons are specified to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, Slight Flow Change
Original intention here was to add what I think is a clarification about how the reporting functions send the signal back to the ad tech's servers. As I was digging through I figured a beacon would be used and I thiiink that is supported by slightly-above-cursory-inspection here.
As I went to write the update I thought it made sense to add it to the paragraph I modified, but wanted it to apply across both reportResult and reportWin, and since that paragraph I think should apply to both as well, I think it makes sense to push it up the "stack" a level. Then, given the move, I changed a few things for flow.
Last thing: as I was writing this PR commit, I realized this might be on the side "not a generic spec piece for any browser implementing Fledge, but still relevant for most readers of this doc"...since I don't think we talked more about that yet, I'm just gonna propose this and we can talk about what makes sense.