-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automatic beacon explainer for new sending behavior #808
Conversation
Will this change also affect ad component fenced frames? |
Yes. This will change the behavior of all automatic beacons, regardless of the frame they originate from.
Correct. Now, any registered destinations will get automatic beacons without the component ad needing to do anything. |
@shivanigithub, would you like to review this PR? |
@maciejkowalczyk There's an update on this feature. We got pushback during a security review and need to modify how this feature behaves. Frames will still need to call What this means for ad components is that they will still need to call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
SHA: 22e7c5b Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Automatic beacons will now send to all URLs that registered with the
reserved.top_navigation
event type, regardless of what data was set when callingsetReportEventDataForAutomaticBeacons()
. However, automatic beacon data will only be included in the beacon if the beacon's destination is specified in thedestination
field when callingsetReportEventDataForAutomaticBeacons()
.