Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FLEDGE_Key_Value_Server_API.md #726

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

thegreatfatzby
Copy link
Contributor

Looking for clarity disguised as commit, main page indicates interest group names being concatenated and added to the KV call for commong kv URLs, and table below mentions multiple IG names, want to make sure I'm understanding.

Looking for clarity disguised as commit, main page indicates interest group names being concatenated and added to the KV call for commong kv URLs, and table below mentions multiple IG names, want to make sure I'm understanding.
@peiwenhu
Copy link
Contributor

This doc is written by Protected Audience's TEE K/V server implementation (which will replace the BYOS servers in the future) and the APIs are what it'll support.
V1 is aligned to the BYOS API described in the main doc. However, some advanced features like concatenated IG names are not supported in TEE K/V server.
V2 which is probably what you saw that has multiple IG names, is specific to the TEE implementation that has more privacy protections. BYOS k/v servers are not expected or supported to use it.

Because we don't intend to support IG names in V1, the commit probably won't be necessary but we can continue with the clarification here if necessary.

@thegreatfatzby
Copy link
Contributor Author

Hey @peiwenhu , so for the "v1" of BYOS server, the auction code will concatenate the IG names for any identical KV server URLs if the appropriate parameter is included?

@brusshamilton
Copy link
Contributor

Yes, for the BYOS method the bidding signal fetch URL will contain both the keys and the interest group names. As with the keys, the interest group names will be URL escaped and then joined into a comma separated list.
See the Chrome implementation here: https://source.chromium.org/chromium/chromium/src/+/main:content/services/auction_worklet/trusted_signals.cc;l=370

Note that the list of interest groups is only intended to be used to fetch the corresponding priority vectors in the response. The list of interest groups specifically should not control the return value for other keys or implement any operations based on the set of interest groups a user is a member of (or not a member of).

@thegreatfatzby
Copy link
Contributor Author

@brusshamilton will there be some Terms of Service for an Ad Tech using these APIs to enforce that and other BYOS restrictions?

thegreatfatzby and others added 2 commits October 9, 2023 20:13
Co-authored-by: Paul Jensen <JensenPaul@users.noreply.github.com>
@JensenPaul JensenPaul merged commit dad42d0 into WICG:main Nov 28, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 28, 2023
SHA: dad42d0
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants